Skip to content

Performance test config #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mo-marqh wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Performance test config #82

mo-marqh wants to merge 7 commits into from

Conversation

@mo-marqh
Copy link
Member

@mo-marqh mo-marqh commented Dec 31, 2025 •
edited
Loading

PR Summary

Sci/Tech Reviewer: @harry-shepherd
Code Reviewer: @t00sa

This stand alone change is part of a change set targeting performance management and optimisation, derived from https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1002

this change set targets the configuration of tests, MPI management, I/O server interfacing and output file setup.

There are no linked or blocking issues for this change, though further changes will depend on it.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
    style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource
    and have tests been allocated to an appropriate testing group (i.e. the
    developer tests are for jobs which use a small amount of compute resource
    and complete in a matter of minutes)

Test Suite Results - lfric_apps - spareperformanceTestConfig/run3

Suite Information

Item Value
Suite Name spareperformanceTestConfig/run3
Suite User mark.hedley
Workflow Start 2026-01-21T07:54:11
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@2025.12.1 True
lfric_apps mo-marqh/lfric_apps@funcSpaceEnum False
lfric_core MetOffice/lfric_core@aa32824 True
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

✅ succeeded tasks - 1456

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

PSyclone Approval

  • If you have edited any psyclone related code (eg. PsyKAl-lite, Kernal
    inteface, optimisation scripts, LFRic data structure code) then please
    contact the
    tooscollabdevteam@metoffice.gov.uk

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Dec 31, 2025
@harry-shepherd
Copy link
Contributor

harry-shepherd commented Jan 16, 2026

Thankyou for adding the comments to the XML file.

t00sa
t00sa reviewed Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regress the two CPE changes? I don't think they're necessary. Also, you will need to sign the CLA and merge the branch up to head of main before the PR can be merged.

@mo-marqh
Copy link
Member Author

mo-marqh commented Jan 20, 2026

Can you regress the two CPE changes? I don't think they're necessary. Also, you will need to sign the CLA and merge the branch up to head of main before the PR can be merged.

thank you @t00sa
I have updated the branch to
prefer cpe/23.05 and load cray-mpich/8.1.27
and rerun developer tests, with updated results reported in the ticket

i hope this is now more comfortable for you

t00sa
t00sa reviewed Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion...

@github-actions github-actions bot added cla-modified The CLA has been modified as part of this PR - added by GA and removed cla-signed The CLA has been signed as part of this PR - added by GA labels Jan 20, 2026
@mo-marqh mo-marqh force-pushed the performanceTestConfig branch from 2e1648e to 9b59784 Compare January 20, 2026 17:46
@mo-marqh
Copy link
Member Author

mo-marqh commented Jan 20, 2026

i fixed the suite-config for ex1a as you requested @t00sa

there was an odd conflict and an ongoing issue with CLA that's recently gone onto main so i took the liberty of rebasing to main and re-pushing.
i've left the tests rerunning and i'll pick up results in the morning and re-update the ticket

hope that's okay

@mo-marqh
Copy link
Member Author

mo-marqh commented Jan 21, 2026

i fixed the suite-config for ex1a as you requested @t00sa

there was an odd conflict and an ongoing issue with CLA that's recently gone onto main so i took the liberty of rebasing to main and re-pushing. i've left the tests rerunning and i'll pick up results in the morning and re-update the ticket

hope that's okay

updated test results in comment:
group=all
succeeded tasks - 1456

@t00sa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t00sa t00sa t00sa left review comments

@harry-shepherd harry-shepherd harry-shepherd approved these changes

Assignees

@harry-shepherd harry-shepherd

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mo-marqh @harry-shepherd @t00sa